search

ros-melodic-arch / ros-melodic-gazebo-msgs

ros-melodic-gazebo-msgsAUR package
0 stars 0 forks source link

fix spawning model issue #3

Closed acxz closed 4 years ago

acxz commented 4 years ago

Resolves #2

jwhendy commented 4 years ago

I can probably try this later this week. This is about their library, not the patch, but checking type(foo) == type is not the RightWay(TM).

It should either be if type(_x) is str or if isinstance(_x, str).

acxz commented 4 years ago

Sure, there are definitely deeper things here that can be done properly. But for the sake of pushing out a fix ASAP for end users this is good enough. @bionade24 if this can be pushed out along with https://github.com/ros-melodic-arch/ros-melodic-gazebo-ros/pull/5 that would be much much appreciated since the relevant issues are putting a hold on using Gazebo with ROS.

acxz commented 4 years ago

Merging in since no activity since 7 days.