search

ros-misc-utilities / ffmpeg_image_transport

ROS2 image transport plugin for encoding/decoding with h264 codec
Apache License 2.0
65 stars 22 forks source link

Configurable CRF? #30

Closed tonynajjar closed 3 months ago

tonynajjar commented 3 months ago

CRF is the first configuration point in the website but doesn't seem configurable. Any good reason or just not implemented?

berndpfrommer commented 3 months ago

I wasn't aware of CRF, if that qualifies as a good reason. I don't see any CRF setting in the AVCodecContext struct. Way back when I wrote the first version of this I got to where I wanted by tuning "qmax". Be happy to see a PR to add a knob for CRF.

tonynajjar commented 3 months ago

I see it here which is version 0.6. Your points to "trunk", not sure what that is. I think it was removed in later versions... not sure why or where it was added instead

tonynajjar commented 3 months ago

I searched for a bit and really don't see an obvious way to do this. I guess I'll content myself with other knobs for the time being