ros-misc-utilities / ffmpeg_image_transport

ROS2 image transport plugin for encoding/decoding with h264 codec
Apache License 2.0
65 stars 22 forks source link

Fix for #3 #4

Closed akssri-sony closed 1 year ago

akssri-sony commented 1 year ago

src/ffmpeg_decoder.cpp:

src/ffmpeg_encoder.cpp:

berndpfrommer commented 1 year ago

Does this PR fix issue #3 altogether? Or does it just allow to run with non-32-bytes line width?

berndpfrommer commented 1 year ago

The fails seem to be all formatting related. You can fix the formatting by running e.g.

clang-format -i ffmpeg_decoder.cpp

(You need to run this in the source tree such that clang-format finds the format config file)

akssri-sony commented 1 year ago

Apologies; have fixed the format now.

The PR fixes both issues:

akssri-sony commented 1 year ago

Ah! Forgot that this evaluates to (a == b) == c in CXX; fix pushed.

berndpfrommer commented 1 year ago

@akssri-sony Thank you for contributing this fix!