Closed akssri-sony closed 1 year ago
Your question leaves me confused. It seemed to me like your conditional checking for BGR24 was added precisely because you had an encoder that worked directly off of BGR24. Is that not so? Then how did you test the code?
I haven't tested this code path.
This PR fixes both 1. and 2.
I tested on a mix of ROS2 galactic and ROS2 humble using nvenc and it works. Not sure what code paths have been tested, but at least for me there was no regression. Thanks again for the fixes!
Apologies; there was another bug in the previous PR. Also changed the target fmt from AV_PIX_FMT_BGR0 (4-bytes per pixel position) to AV_PIX_FMT_BGR24.
(BTW, are there encoders that directly encode BGR24 ? Maybe by going to YUV422 ? )