search

ros-mobile-robots / diffbot

DiffBot is an autonomous 2wd differential drive robot using ROS Noetic on a Raspberry Pi 4 B. With its SLAMTEC Lidar and the ROS Control hardware interface it's capable of navigating in an environment using the ROS Navigation stack and making use of SLAM algorithms to create maps of unknown environments.
https://ros-mobile-robots.com
BSD 3-Clause "New" or "Revised" License
275 stars 82 forks source link

Fix base_controller build #90

Closed santerioksanen closed 3 months ago

santerioksanen commented 4 months ago

As I mentioned in https://github.com/ros-mobile-robots/diffbot/issues/89, I couldn't build the base_controller with PlatformIO.

This PR:

The change in diffbot_base/scripts/base_controller/lib/base_controller/base_controller.h I am not totally sure of, but with the change in place I am able to build and run the project.

fjp commented 3 months ago

Thanks @santerioksanen for fixing this and the new github workflow 👍

The compiler on Ubuntu 20.04 is actually warning about unsigned int:

image https://www.youtube.com/watch?v=Mn6DY1tNUcU

The reason this might have been treated as a warning on Ubuntu 20.04 but now as an error on Ubuntu 22.04 could be due to differences in the compiler or compiler settings between the two Ubuntu versions. It's possible that the compiler in Ubuntu 22.04 is stricter about type mismatches and now treats them as errors by default, whereas the compiler in Ubuntu 20.04 may have been more lenient. Anyway it is good that your PR fixes this issue

Closes #89