search

ros-naoqi / libqi-release

Release repo of the ROS port of Aldebaran's libqi
https://github.com/ros-naoqi/libqi
0 stars 11 forks source link

Package for ROS Melodic #6

Closed mbusy closed 4 years ago

mbusy commented 5 years ago

This issue is basically the same as #5, for the Melodic distro. Having naoqi_libqi (and naoqi_libqicore) released for Melodic would really be useful to researchers

mbusy commented 4 years ago

Small update on the subject: I adapted the code of libqi-release (here) and libqicore-release (here) so that they could be compiled with melodic.

I am not completely familiar with the package release process, but from what I understand looking at the network of the repo, the modifications could be committed to "release/melodic/naoqi_libqi(core)" branches, before releasing the packages for melodic. I would like to submit PRs, but such branches don't yet exist on the base repositories.

@suryaambrose, @mikaelarguedas, how should I proceed ?

mikaelarguedas commented 4 years ago

As a general rule, code change should always live in the source repositories and not be pushed by hand to the -release repositories. Release repositories take a snapshot of the source repositories (import a specific version) and then apply release patches + automagically add the files required by the packaging system of the targeted platforms (e.g. Debian control and rule files).

Answers needed before releasing:

Then the release process is highlighted in http://wiki.ros.org/bloom/Tutorials/ReleaseThirdParty

Basically you need to:

HTH,

Edit: some info at https://github.com/ros-naoqi/libqi-release/pull/2#issuecomment-188300455 too

mbusy commented 4 years ago

Thanks, yes that helps :)

What version of the software (libqi / libqi_core) should be released in Melodic?

I would say 2.5.0/2.3.1, the ones used for the kinetic release (I did my tests with these versions), but that's debatable

Does that version have a release branch / tag on the source repository? does it build as is or requires additional patches?

If we select the versions used for the kinetic release, then yes. Yep, additional patches are required in order to build

One last question: I don't have the permission to edit this repo. Adding a package.xml in a melodic folder shouldn't be a problem (I will submit a PR), but for the second step (running bloom) my guess is that you need to have access to the base repo right ?

mikaelarguedas commented 4 years ago

I would say 2.5.0/2.3.1the ones used for the kinetic release (I did my tests with these versions), but that's debatable

As this repo points to 2.7.0 for lunar, it seems to me that it's make more sense to target a more recent version and minimise dependency descrepancies (like boost). Not sure what OS / dep versions 2.9.0 supports but it seems like a good/recent candidate. Then if it makes more sense to focus on 2.5.0 for some reason I'd be fine with that as well but will require more patching which in general I prefer to avoid (whatever can be fixed / is already fixed upstream should be reused)

I don't have the permission to edit this repo.

As the main maintainer/releaser of these packages, my conviction is that you should have access to all repos of this organization. @nlyubova @zygopter @suryaambrose are you ok with me promoting Maxime as an owner of ros-naoqi?

(I will submit a PR), but for the second step (running bloom) my guess is that you need to have access to the base repo right ?

I apparently still have power here so I can merge / run bloom if needed, but hopefully you'll unlock god-mode before then ;)

nlyubova commented 4 years ago

@mikaelarguedas fine for me

mikaelarguedas commented 4 years ago

@Pandhariix congrats you're now an owner of ros-naoqi !

Noticed 2FA is disabled on your account, I'd recommend enabling it to avoid bad surprises :)

mbusy commented 4 years ago

I thought the repo was pointing towards 2.5.0 for lunar, my bad... In any case you're right it would make more sense to target a recent version, I'll try to see how the 2.9.0 performs :)

Thanks for the god-mode! (2FA now enabled)

mikaelarguedas commented 4 years ago

I thought the repo was pointing towards 2.5.0 for lunar, my bad...

Actually you're right it's pointing to 2.5.0, not sure where I got the idea of 2.7 from. I guess I mixed up 2.5.7 and 2.7 when rereading the lunar thread >_<.

mbusy commented 4 years ago

Another small update: I managed to compile naoqi_libqi and naoqi_libqicore for melodic, using the 2.9.0 releases of libqi and libqicore (patches to be applied on the upstream code here).

A few adaptations are required in naoqi_driver to be able to compile it (melodic_compatibility branch of this fork), but the code is still compatible with older ros distros.

The driver seems to be running fine, I'll eventually release the packages for melodic next week :)

iProzd commented 4 years ago

Small update on the subject: I adapted the code of libqi-release (here) and libqicore-release (here) so that they could be compiled with melodic.

I am not completely familiar with the package release process, but from what I understand looking at the network of the repo, the modifications could be committed to "release/melodic/naoqi_libqi(core)" branches, before releasing the packages for melodic. I would like to submit PRs, but such branches don't yet exist on the base repositories.

@suryaambrose, @mikaelarguedas, how should I proceed ?

Thanks for your update, but the links seem to be lost, have you got any new accessible update?

mbusy commented 4 years ago

Extra modifications were added to the repos, the snippets weren't relevant anymore. You can check the release/melodic/naoqi_libqi and release/melodic/naoqi_libqicore branches of the repos if you want to compile naoqi_libqi and naoqi_libqicore by yourself.

Or you could wait for the pacakges to be released (hopefully pretty soon)

mbusy commented 4 years ago

Bit of a necropost, but the package was released for melodic along with other useful ROS packages for Pepper and NAO (see Melodic sync 2020-01-16)