search

ros-naoqi / nao_extras

Additional ROS nodes for the Nao humanoid, continues from the "nao_common" stack
BSD 3-Clause "New" or "Revised" License
8 stars 20 forks source link

Face detection support #4

Closed etsardou closed 10 years ago

etsardou commented 10 years ago

Taking over from https://github.com/ros-nao/nao_robot/pull/22, adds a ROS interface for the NAO's ALFaceDetectionProxy.

ahornung commented 10 years ago

Actually, I think that the message should be merged into nao_msgs, I don't think there's a need for a separate nao_extras_msgs. Looks cleaner to me to have them all in one place.

etsardou commented 10 years ago

Hmm I though you wanted to keep separated the two repositories. In the current implementation the face detection module is totally independent to the nao_driver. Do you prefer to make two pull requests in both repos?

ahornung commented 10 years ago

Ah, I see... not really sure then. What do @severin-lemaignan @vrabaud @danielmaier think?

danielmaier commented 10 years ago

I think it would be better to have separate messages for nao_extra stuff. Not sure if they should be called nao_extra_msgs or be more specific (like nao_interaction_msgs, etc.).

skadge commented 10 years ago

I agree with @danielmaier : I would have them here in nao_extra repo, but in a noo_interaction_msgs package. Or maybe even better, we could create a new nao_interaction repo: I do not like too much the way nao_extras sounds like a bit of a 'messy corner' in my poor head ;-)

vrabaud commented 10 years ago

+1 for nao_interaction

etsardou commented 10 years ago

I am starting to add more functionalities concerning the NAOQi Vision modules. It agree with @skadge 's idea for nao_interaction repo. I could add the C++ wrappers I mentioned in the googlegroup mailing list there as well.

ahornung commented 10 years ago

So this can be closed, right? You can then simply create nao_interaction in your own namespace and when all is done we could transfer it into ros-nao, if you want to.

etsardou commented 10 years ago

Yes I think this can be closed. Though in my opinion its best to create the repo in ros-nao. That way I will fork it and work with pull requests (or even better I could work directly on the repo with branches and pull request to the devel - I don't know your policy on these subjects), as I am not sure when "all will be done" . I don't have any time schedule or goals for now, I just keep on programming :)