search

ros-naoqi / nao_robot

BSD 3-Clause "New" or "Revised" License
53 stars 60 forks source link

Rename launch files #11

Closed Karsten1987 closed 9 years ago

Karsten1987 commented 9 years ago

Cleanup for nao_robot. This involves removing several launch files in nao_description

Furthermore, launch files inside nao_apps are renamed. However, please note that I only renamed the launch files. I did not rename python scripts in order to avoid wrong python imports. @k-okada Could you please try the nao_apps folder before merging? I am not familiar with the code base inside of it.

thx

vrabaud commented 9 years ago

nao_apps/launch/nao_speech.launch → nao_apps/launch/leds.launch ?

k-okada commented 9 years ago

This seems ok to me. Do you going to change package name as well? Something like naoqi_apps?

Karsten1987 commented 9 years ago

fixed issues.

it seemed that nao_leds.launch got accidentally overwritten. So the leds.launch does now start leds.py again.

vrabaud commented 9 years ago

Why the upload_nao name ? nao_desc_generated.launch → nao_description/launch/upload_nao.launch

While you're at it, please move the old URDFs from https://github.com/ros-naoqi/nao_robot/tree/master/nao_description/urdf into their own "deprecated" folder

vrabaud commented 9 years ago

+1