search

ros-naoqi / nao_robot

BSD 3-Clause "New" or "Revised" License
52 stars 60 forks source link

configure sonars via namespace and params #12

Closed Karsten1987 closed 9 years ago

Karsten1987 commented 9 years ago

See the following issues and PR

this is the launch file change for the following PR on naoqi_bridge: https://github.com/ros-naoqi/naoqi_bridge/pull/25

see also https://github.com/ros-naoqi/naoqi_bridge/pull/21 @k-okada do you agree with that?

Karsten1987 commented 9 years ago

well, afaik this is simply when the option is unfold. Might be a minor thing though, no ?

k-okada commented 9 years ago

sure, this is better than https://github.com/ros-naoqi/naoqi_bridge/pull/21,

Karsten1987 commented 9 years ago

see PR: https://github.com/ros-naoqi/naoqi_bridge/pull/25

vrabaud commented 9 years ago

thx. Those changes are welcome but do not seem to require a release right ? (same with https://github.com/ros-naoqi/naoqi_bridge/pull/25)