sonar frames are inverted left-right

ros-naoqi / nao_robot

BSD 3-Clause "New" or "Revised" License

53 stars 60 forks source link

sonar frames are inverted left-right #15

Closed vrabaud closed 9 years ago

vrabaud commented 9 years ago

Just open up a tf in RViz and you'll see the problem. @keulYSMB , didn't that happen before ?

mikaelarguedas commented 9 years ago

Yes and it has been fixed a few months ago. I think some commits have been lost or history has been overwritten at some point because it's not the first time a previously fixed bug shows up. Do you want me to fix it ? Can you ask sbarthelemy to generate an URDF to see if the problem is in Aldebaran's library ?

mikaelarguedas commented 9 years ago

I fixed it at the beginning of January indeed (while fixing the gazebo files). We just need another release.

vrabaud commented 9 years ago

So you fixed it for V40 but not for V50. I am still releasing but as you said, this has to be a bug in our internal library. Still, releasing for now.

vrabaud commented 9 years ago

The error comes from here no ? https://github.com/ros-naoqi/naoqi_bridge/blob/master/naoqi_tools/src/naoqi_tools/nao_dictionaries.py#L56

mikaelarguedas commented 9 years ago

Yes Definitely ! Stupid copy paste mistake :s