Introduce sleep in pose controller

ros-naoqi / naoqi_bridge

ROS stack to interact with NAOqi

BSD 3-Clause "New" or "Revised" License

31 stars 45 forks source link

Introduce sleep in pose controller #90

Open warp1337 opened 6 years ago

warp1337 commented 6 years ago

The pose controller consumes 100% CPU because the controller thread does not sleep. I commented in the corresponding commit.

nlyubova commented 6 years ago

Thank you for reporting, do not hesitate to make a pull request

warp1337 commented 6 years ago

That's basically ONE line. Sorry but, forking, cloning, pushing, open pr, merge, close, remove fork, etc... That's just not justifiable for one LOC. Maybe the author can do that @kochigami ?

nlyubova commented 6 years ago

@warp1337 sorry but I do not have a robot to test it

nlyubova commented 6 years ago

@warp1337 luckily github allows to do a Pull Request from a browser :) with no need of fork, clone, merge, ...

nlyubova commented 6 years ago

Help wanted to test the master on Pepper and Nao. Could somebody do it? to check this commit https://github.com/ros-naoqi/naoqi_bridge/commit/2bb282b5c063a40f0ba38e525c3cb5dfdb854584 ?