search

ros-naoqi / naoqi_driver

c++ bridge based on libqi
Apache License 2.0
54 stars 93 forks source link

pass rosdep eol flag #123

Closed mikaelarguedas closed 4 years ago

mikaelarguedas commented 4 years ago

rosdep database is not up to date as these images have been EOL for a while. Running rosdep update with the --include-eol-distros flag should hopefully fix the rosdep install error.

Travis should most likely fail the job when a command fail rather than trying to build anyway

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

mbusy commented 4 years ago

Nice, that will fix the CI. The indigo build still seems to fail, due to the use of std::nan, I'll switch to std::numeric_limits::quiet_NaN(), that should fix the issue.

EDIT: There is apparently an issue with Orocos KDL for the kinetic build, do you have any idea why ?

nlyubova commented 4 years ago

Thanks Mikael !

mikaelarguedas commented 4 years ago

There is apparently an issue with Orocos KDL for the kinetic build, do you have any idea why ?

Yeah just noticed that happened on master's latest commit https://github.com/ros-naoqi/naoqi_driver/commit/3a4db0ccbd59cd94b443734214f609244db2225f didnt look into it though :man_shrugging:

mbusy commented 4 years ago

That's weird, nothing seems to be related to KDL in that commit

mbusy commented 4 years ago

In any case this will fix the rosdep issue, thanks for the contrib Mikael!

mikaelarguedas commented 4 years ago

That's weird, nothing seems to be related to KDL in that commit

Yeah my guess is mismatching package version (due to outdated images). like it's looking for a specific soabi of orocos libraries and thats not the same as the one in the image. Testing a fix locally wil update a follow-up PR