search

ros-naoqi / naoqi_driver

c++ bridge based on libqi
Apache License 2.0
52 stars 93 forks source link

missing romeo.urdf #39

Closed nlyubova closed 9 years ago

nlyubova commented 9 years ago

Could we add the romeo.urdf ?

vrabaud commented 9 years ago

@Karsten1987 , what were the problems in loading the urdf from the proper *_description packages ?

Karsten1987 commented 9 years ago

It's only for qibuild purposes. Have a look in here: https://github.com/ros-naoqi/naoqi_driver/blob/master/src/helpers/filesystem_helpers.hpp#L115

We could replace the rospack call from naoqi_driver to nao_description, pepper_description etc, but we'd still have to keep a local copy of each URDF when building with qibuild.

Karsten1987 commented 9 years ago

@nlyubova could you please verify that the joint_state publisher works fine? Just launch it with a ROMEO and check if you see it in RViz. Have a look at https://github.com/ros-naoqi/naoqi_driver/blob/master/src/converters/joint_state.cpp and also at the according files for sonar.

nlyubova commented 9 years ago

@Karsten1987 , that would be great to replace the rospack call from naoqi_driver to robot_description but we should also pass the BodyVersion for the path, like "pepper1.0_generated_urdf" or "naoV40_generated_urdf"

For testing, I've made a romeo_bringup and it works well with the naoqi_driver except of calls to ALBodyTemperature and ALAutonomousLife.

By the way, do you know why fingers are missing for all the robots ?

Karsten1987 commented 9 years ago

@nlyubova The problems with the fingers got resolved in here https://github.com/ros-naoqi/naoqi_driver/pull/42

For the rest can this be merged? I cannot verify this PR remotely.

vrabaud commented 9 years ago

@nlyubova , please rebase and push to your repo, you have way too many changes

vrabaud commented 9 years ago

The romeo urdf has a lot of personnalization so I am against it.

vrabaud commented 9 years ago

can you please not commit the URDF of your Romeo so that we can merge that commit ? Thx.

nlyubova commented 9 years ago

Ok, that was for the demo, sorry for that On Oct 14, 2015 6:59 PM, "Vincent Rabaud" notifications@github.com wrote:

can you please not commit the URDF of your Romeo so that we can merge that commit ? Thx.

— Reply to this email directly or view it on GitHub https://github.com/ros-naoqi/naoqi_driver/pull/39#issuecomment-148117067 .