Fix termination issues - Githubissues

ros-naoqi / naoqi_driver

c++ bridge based on libqi

Apache License 2.0

52 stars 93 forks source link

Fix termination issues #62

Closed suryaambrose closed 8 years ago

suryaambrose commented 8 years ago

This PR fixes the segfault happening every time the bridge is terminated.

@k-okada I also took the liberty of including your commit to fix the termination error due to tactile and bumpers, hope you don't mind. If you do I'll remove it.

This fixes #57 and the other problems discussed in #61 (not including the deadlock caused by audio yet, but it is on the way)

vrabaud commented 8 years ago

LGTM, @k-okada , feel free to merge and release.

suryaambrose commented 8 years ago

These last two commits fix audio and a compilation issue I had with qibuild. It does not seem to impact compilation with catkin. This pull request fixes:

segfault on termination due to bad session destruction
segfault on termination due to incorrect bumper/tactile unsubscribe (thanks @k-okada for the fix)
deadlock on termination due to audio mutex concurrency