search

ros-naoqi / pepper_meshes

Pepper robot meshes
Other
5 stars 6 forks source link

Melodic release #5

Closed rhaschke closed 4 years ago

rhaschke commented 5 years ago

Please release for Melodic.

mbusy commented 4 years ago

On it.

@mikaelarguedas: everything seems to be running just fine (tested a local prerelease), but bloom complains about the java rosdep key for stretch:

Failed to resolve java on debian:stretch with: Error running generator: Failed to resolve rosdep key 'java', aborting.
java is depended on by these packages: ['pepper_meshes']
mikaelarguedas commented 4 years ago

everything seems to be running just fine (tested a local prerelease), but bloom complains about the java rosdep key for stretch

This means that the prerelease using stretch should fail and not run fine right ?

Taking a step back here: Is this installer needed at all anymore ?

It looks like the meshes are finally public and under the apache 2 license meaning we don't need the installer anymore with license agreement anymore. So ideally this package would just get the meshes from qibullet and install them in a ROS package, no more installer and shady patches :tada:

mbusy commented 4 years ago

This means that the prerelease using stretch should fail and not run fine right ?

In my opinion yes, but for some reason the prerelease runs fine...

Regarding the second point, it would definitely be better, I agree. On the other hand, we wanted to replace the meshes - that are starting to get very old :smile: - with a more up-to-date version. But I guess that we won't be able to easily release those updated meshes, and we will potentially need an installer...

So for now, I'd rather keep the current structure for the release (eventually removing the java building dependency), and for the next one either propose a new installer or simply fetching the meshes in another repo (for melodic and kinetic as well)

mikaelarguedas commented 4 years ago

In my opinion yes, but for some reason the prerelease runs fine...

Maybe you ran your prerelease only for ubuntu and did not run one for debian stretch?

generate_prerelease_script.py \
  https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml \
  melodic default **ubuntu bionic** amd64

Regarding the second point, it would definitely be better, I agree. On the other hand, we wanted to replace the meshes - that are starting to get very old smile - with a more up-to-date version. But I guess that we won't be able to easily release those updated meshes, and we will potentially need an installer...

The current installer doesn't work on ARM so any way to fetch the meshes without the installer would be an improvement. If the meshes can now be put on a repo without explicit license agreement, could we just push the meshes here or pull them from qibullet and avoid the need for an installer?

If we end up needing an installer for future meshes, it would be good to use the same for ROS and qibullet as well as having one that works across platform and architectures.

eventually removing the java building dependency

My recollection (though it was multiple years ago) is that, as long as we use this installer, the java dependency cannot be removed. When the buildfarm builds the package it needs to have java installed to run the installer

Opened https://github.com/ros/rosdistro/pull/23428 with the rule

The kinetic package for pepper_meshes is broken (doesn't display the license agreement on install) while the indigo one does. This should likely be fixed before releasing into melodic

mikaelarguedas commented 4 years ago

The kinetic package for pepper_meshes is broken (doesn't display the license agreement on install) while the indigo one does. This should likely be fixed before releasing into melodic

I should be able to fix this if needed. Question is: is it still needed ?

mbusy commented 4 years ago

Maybe you ran your prerelease only for ubuntu and did not run one for debian stretch?

I might have been a bit fast on that one, I pretested the build on local dockers (bionic and stretch, works fine), but only tried the prerelease for bionic... It indeed fails for stretch.

The current installer doesn't work on ARM so any way to fetch the meshes without the installer would be an improvement. If the meshes can now be put on a repo without explicit license agreement, could we just push the meshes here or pull them from qibullet and avoid the need for an installer?

If we end up needing an installer for future meshes, it would be good to use the same for ROS and qibullet as well as having one that works across platform and architectures.

Someting that I failed to mention, the qibullet meshes are not identical to the ROS ones, the meshes had to be adapted for bullet... Just pulling the meshes won't do it, they will have to be "reverted" to their initial state (since the changes were made manually, I don't have a script to do so).

Regarding the second comment, I agree, the same installer would be good, I would add extra installation rules in qibullet to adapt the meshes.

So for now, even though it's not ideal, I think that it's better to keep things that way, with the fix for the kinetic package. In the meantime, I'll see internally how I can release the updated meshes, to have a unified way of installing that

mikaelarguedas commented 4 years ago

So for now, even though it's not ideal, I think that it's better to keep things that way, with the fix for the kinetic package. In the meantime, I'll see internally how I can release the updated meshes, to have a unified way of installing that

Awesome

mikaelarguedas commented 4 years ago

@Pandhariix if it's fine with you, I'll make the melodic release and post a comment with all the relevant PRs here to ease future release (e.g. upcoming Noetic)

mbusy commented 4 years ago

@mikaelarguedas sure, thanks !

mikaelarguedas commented 4 years ago

PRs:

Process to release:

mikaelarguedas commented 4 years ago

pepper_meshes has been released for ROS Melodic and should be available in the next melodic sync.

If you want to give a try to the package right now you can install it from the testing repository