search

ros-naoqi / pepper_robot

Meta-package for basic Pepper robot-related packages
25 stars 47 forks source link

launch/pepper_full.launch : support nao_port in launch/naoqi_driver.launch https://github.com/ros-naoqi/naoqi_driver/pull/52 #13

Closed k-okada closed 8 years ago

k-okada commented 9 years ago

this requires https://github.com/ros-naoqi/naoqi_driver/pull/52

vrabaud commented 8 years ago

We shoudl really rename those nao_port and nao_ip to port and ip no ? @suryaambrose ?

suryaambrose commented 8 years ago

Don't know. As there is a "roscore_ip" I think it makes sense to prefix all _ip arguments with a name to specify which ip we are talking about. But since nao is not the only robot, maybe this can be indeed changed to robot_ip or naoqi_ip ? And then, same change for "nao_port" for consistency ?

k-okada commented 8 years ago

+1 for nao_ip or naoqi_ip

◉ Kei Okada

On Tue, Dec 22, 2015 at 12:16 AM, Surya Ambrose notifications@github.com wrote:

Don't know. As there is a "roscore_ip" I think it makes sense to prefix all _ip arguments with a name to specify which ip we are talking about. But since nao is not the only robot, maybe this can be indeed changed to robot_ip or naoqi_ip ? And then, same change for "nao_port" for consistency ?

— Reply to this email directly or view it on GitHub https://github.com/ros-naoqi/pepper_robot/pull/13#issuecomment-166327465 .

vrabaud commented 8 years ago

+1 for naoqi_ip too.