Closed nlyubova closed 8 years ago
@kochigami I'm +1 for your proposal (320x240 and set near clip to 0.05), could you create new Pr for this?
@k-okada , I'll fix my PR, but why should we use 320x240 ?
@kochigami thank you for your work, let's see what should we update:
I thought if the real robot publishes 320x240, we expect simulation is also publish same size.
◉ Kei Okada
On Mon, Sep 5, 2016 at 5:38 PM, Natalia Lyubova notifications@github.com wrote:
@k-okada https://github.com/k-okada , I'll fix my PR, but why should we use 320x240 ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros-naoqi/pepper_robot/pull/23#issuecomment-244690511, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3JZ84EYrih149jnPCmgM8NtvPbGBks5qm9UUgaJpZM4JC5zw .
the real robot publishes the resolution that we ask it. In naoqi_driver, 320x240 is a default resolution but you can choose any resolution in the config file. 640x480 is the official maximum resolution, and both work well
regarding the distortion parameters, the one I've taken are from naoqi_driver, it is better to keep them like it is (to correspond to the one real robot publish)
Please, check the updated PR, and let's merge sensors because we need them as well
@kochigami please check if this is ok for you.
Sorry for just commenting with my bad English and thank you very much for your kind reply. This pull request is ok for merge!
I got the reason why the image size is 640x480. Thank you very much.
Hi, I'd like to use sensor data on pepper gazebo, but I'm a newbie. I have one question and one small comment on adding 2D camera plugins on pepperGazebo.xacro. Before I found #23, I tried writing my own codes (I'll show it below). So I compared two codes.
Question about image size: I think the size of image topic (
/pepper_robot/camera/front(bottom)/image_raw
) is width: 320 and height: 240, but pepper documentation says width: 640 and height: 480.23 follows the documentation, but I'm not sure which (320x240 or 640x480) is right...
I found nao gazebo also uses 640x480 and there is no difference on image viewer though.
Small comment on bottom camera topic: I found the reason why the min value of focus range is set to 0.05 instead of 0.3 is avoiding showing split pepper's hands. I think it's helpful for following why 0.05 is set if there is some comments on the value.
The code is here:
my code (I set 0.3 based on the documentation)
pull request 23 (0.05 is set)
My code is like this:
In order to obtain distortionK1/ K2/ K3/ T1/ T2, I excuted
(and this returns the image size as width: 320, height: 240)