search

ros-naoqi / pepper_robot

Meta-package for basic Pepper robot-related packages
25 stars 47 forks source link

[pepper_robot] disable odom with param #26

Open Naoki-Kameyama opened 8 years ago

Naoki-Kameyama commented 8 years ago

Because I'd like to use Visual SLAM with Pepper.

Pleas merge this PR after https://github.com/ros-naoqi/naoqi_bridge/pull/58

mikaelarguedas commented 8 years ago

closing/opening to trigger new travis job

k-okada commented 8 years ago

I think we have to release naoqi_bridge I also think we should set true as default value until someone provide (v)slam code/launch in this repository.

mikaelarguedas commented 8 years ago

yes we'll need to wait for naoqi_bridge to be released indeed. Agreed for the default value, I think it should be set to false as in the parent PR. @Naoki-Kameyama could you update your PR with the default value set to true ?

mikaelarguedas commented 8 years ago

thanks @Naoki-Kameyama Waiting until next naoqi_bridge to squash and merge this

Naoki-Kameyama commented 8 years ago

Thank you for pointed.

Naoki-Kameyama commented 8 years ago

This PR is required to release naoqi_bridge https://github.com/ros-naoqi/naoqi_bridge/pull/59.

yoneken commented 8 years ago

His claim is seems to be satisfied now! https://github.com/ros/rosdistro/pull/12759

Karsten1987 commented 8 years ago

what about extending this config file and then set the parameter manually once vslam is available?

Karsten1987 commented 8 years ago

any updates on this?

suryaambrose commented 8 years ago

@Karsten1987 I did not get your point (extending the config file, which is in a different project).

Otherwise, lgtm

mikaelarguedas commented 7 years ago

@nlyubova same thing as https://github.com/ros-naoqi/pepper_robot/pull/37#issuecomment-289803386, this new argument should be added to naoqi_driver.launch

nlyubova commented 7 years ago

I would agree with @Karsten1987 about the confi file and this is already a parameter in this config file in Naoqi Driver. And here you propose to pass it as a parameter in a launch file to the same Naoqi Driver, so it means that in Naoqi Driver there are will be at least two entries for this parameter (in a launch file and in a config file), so I am not sure if it is a good option or not. @suryaambrose do you think it is ok?