ROS Conventions - Githubissues

ros-naoqi / pepper_robot

Meta-package for basic Pepper robot-related packages

23 stars 47 forks source link

ROS Conventions #38

Open reinzor opened 7 years ago

reinzor commented 7 years ago

Currently, the ROS naming conventions are not met within the ros packages / nodes / configurations of pepper:

Frame names: Should be all lower case underscore separated http://wiki.ros.org/tf2
Topic & node names: Lowercase underscore separated http://wiki.ros.org/ROS/Patterns/Conventions

I could send a PR to fix this, would you be interested?

Karsten1987 commented 7 years ago

Thanks for bringing this up. As of TF, we're aware of this, but the URDF files are mostly generated and comply with the internal libqi/naoqi conventions. AFAIK, the same rule applies for topic names.

reinzor commented 7 years ago

Can't we add a post_script after the auto_generation that transforms camelcases to lowercase underscore?

victorpaleologue commented 11 months ago

It's doable, but wouldn't that break existing code? Unless we publish them in another topic... And then we have to document how to switch from one to the other. It's a bit annoying.

Can we compare that to the consequences of not renaming? What would be wrong if we kept these names this way?