Closed tonynajjar closed 1 year ago
Done I believe. Sorry if it's not as verbose as you would wish but I really need to move on with this contribution; it took much more time than expected
otherwise LGTM in general, but I'll let @AlexeyMerzlyakov review as well when he's back from vacation
One last thing from me - add an entry in the migration guide page for the new node to show off to the users!
One last thing from me - add an entry in the migration guide page for the new node to show off to the users!
Added for Jazzy and Iron, so now we have to backport to Iron :smile:
Just @AlexeyMerzlyakov 's comments left but I'm happy when he is
https://github.com/ros-planning/navigation2/pull/3500