ros-navigation / docs.nav2.org

https://docs.nav2.org/
https://docs.nav2.org/
Apache License 2.0
85 stars 180 forks source link

Add collision detector documentation #451

Closed tonynajjar closed 1 year ago

tonynajjar commented 1 year ago

https://github.com/ros-planning/navigation2/pull/3500

tonynajjar commented 1 year ago

Done I believe. Sorry if it's not as verbose as you would wish but I really need to move on with this contribution; it took much more time than expected

SteveMacenski commented 1 year ago

otherwise LGTM in general, but I'll let @AlexeyMerzlyakov review as well when he's back from vacation

SteveMacenski commented 1 year ago

One last thing from me - add an entry in the migration guide page for the new node to show off to the users!

tonynajjar commented 1 year ago

One last thing from me - add an entry in the migration guide page for the new node to show off to the users!

Added for Jazzy and Iron, so now we have to backport to Iron :smile:

SteveMacenski commented 1 year ago

Just @AlexeyMerzlyakov 's comments left but I'm happy when he is