ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.6k stars 1.3k forks source link

GoalUpdater missing in behavior tree palette for Groot in Foxy #2643

Closed Kaetera closed 3 years ago

Kaetera commented 3 years ago

Bug report

Required Info:

This prevents to display in Groot any behavior tree that use a GoalUpdater node.

Steps to reproduce issue

  1. Create a BTree with a GoalUpdater node:
    <root main_tree_to_execute="MainTree">
    <BehaviorTree ID="MainTree">  
      <GoalUpdater input_goal="{goal}" output_goal="{updated_goal}"/>
    </BehaviorTree>
    </root>
  2. Install Groot from source (classic non-ROS version: https://github.com/BehaviorTree/Groot)
  3. Run Groot app
  4. Load the above tree following the instructions at https://github.com/ros-planning/navigation2/blob/foxy-devel/nav2_behavior_tree/groot_instructions.md 3a. Load the default behavior tree palette that is shipped in navigation2 (https://github.com/ros-planning/navigation2/blob/foxy-devel/nav2_behavior_tree/nav2_tree_nodes.xml) 3b. Import the minimal BTree above

Expected behavior

The import succeed and the tree is displayed in Groot: image

Actual behavior

The import of the tree fails with the following message: image

Additional information

The import fails because this node is note listed in the palette shipped for Foxy. A simple fix is to add it in https://github.com/ros-planning/navigation2/blob/foxy-devel/nav2_behavior_tree/nav2_tree_nodes.xml as it has already been done in the mainbranch :)

    <Decorator ID="GoalUpdater">
      <input_port name="input_goal">Original goal in</input_port>
      <output_port name="output_goal">Output goal set by subscription</output_port>
    </Decorator>
SteveMacenski commented 3 years ago

A PR would be appreciated, thanks!

SteveMacenski commented 3 years ago

Done

WinstonHChou commented 6 months ago

Was the dpkg of nav2-behavior-tree containing this commit released?

SteveMacenski commented 6 months ago

Foxy is no longer a supported distribution.