ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.45k stars 1.24k forks source link

msg validation check for `/initialpose` in `nav2_amcl` #4301

Closed GoesM closed 3 months ago

GoesM commented 4 months ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4294
Primary OS tested on Ubuntu22.04
Robotic platform tested on gazebo simulation of Tally
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Future work that may be required in bullet points

For Maintainers:

GoesM commented 3 months ago

uh.... the error is odd to me error: ‘PoseWithCovarianceStamped’ in namespace ‘geometry_msgs::msg’ does not name a type

My local test (based on ros2-humble) run successfully however failed during CI.

Is the type name different between main and humble ?

SteveMacenski commented 3 months ago

I think you're just missing #include "geometry_msgs/msg/<messsage>.hpp" for the message

GoesM commented 3 months ago

You're right! ^_^

though I'm still confused why it could be built in humble fork ( within my local environment ), T_T, it seems that it doesn't affect much.

I think you're just missing #include "geometry_msgs/msg/<messsage>.hpp" for the message

After all, everything seems fine after changes following your reminder. ^_^