ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.34k stars 1.21k forks source link

[LifecycleManagerClient] clean set_initial_pose and navigate_to_pose #4346

Closed doisyg closed 2 months ago

doisyg commented 2 months ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on Dexory robot

Description of contribution in a few bullet points

I was looking at nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager_client.hpp and noticed 2 methods that do not seem to be used anywhere: set_initial_pose and navigate_to_pose. I guess they can be removed ?

For Maintainers:

SteveMacenski commented 2 months ago

I have no idea why our static analysis tools didn't call this out, thanks!