ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.34k stars 1.21k forks source link

Fix flaky spin, backup behavior test #4349

Closed SteveMacenski closed 2 weeks ago

SteveMacenski commented 2 months ago

Test removed so that CI is green for contributors. Rewriting this test completely is probably required, this is over complicated, fragile, and tries to fake out / bypass parts of things I don't really understand why. We should just populate a costmap, call the server, check results and call it a day.

Removed in: https://github.com/ros-navigation/navigation2/pull/4348

Rewrite the behavior tests using GZ, the Simple Commander API and call this a day.

SteveMacenski commented 2 weeks ago

Done in https://github.com/ros-navigation/navigation2/pull/4515