Description of contribution in a few bullet points
Added CONFIGURE and CLEANUP commands for lifecycle_manager and lifecycle_manager_client
Description of documentation updates required from your changes
I was not able to find any documentation regarding to the available lifecycle transitions. If some exists, would need to that,
Future work that may be required in bullet points
Might be nice to have a test which makes sure that calling shutdown when the nodes are in inactive state does the shutdown properly. I did some testing locally and seems to be working as expected. I tried to add such test into the test_lifecycle_manager.cpp but a problem there is that the shutdown cannot be called multiple times in the same test file, The test environment is not reset between tests since the lifecycle_manager is span up with the launch file. I did not want to write another test file (+ maybe a new launch file) for that 3 line test. Also attempted to change the way the test is ran to have the control over the lifecycle_manager with test fixture but was not successful with that.
For Maintainers:
[ ] Check that any new parameters added are updated in docs.nav2.org
[ ] Check that any significant change is added to the migration guide
[ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
[ ] Check that any new functions have Doxygen added
[ ] Check that any new features have test coverage
[ ] Check that any new plugins is added to the plugins page
[ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
I was not able to find any documentation regarding to the available lifecycle transitions. If some exists, would need to that,
Future work that may be required in bullet points
Might be nice to have a test which makes sure that calling shutdown when the nodes are in inactive state does the shutdown properly. I did some testing locally and seems to be working as expected. I tried to add such test into the test_lifecycle_manager.cpp but a problem there is that the shutdown cannot be called multiple times in the same test file, The test environment is not reset between tests since the lifecycle_manager is span up with the launch file. I did not want to write another test file (+ maybe a new launch file) for that 3 line test. Also attempted to change the way the test is ran to have the control over the lifecycle_manager with test fixture but was not successful with that.
For Maintainers: