search

ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.51k stars 1.27k forks source link

revisit nav2_behavior_tree workarounds #4387

Closed tonynajjar closed 3 months ago

tonynajjar commented 4 months ago

@SteveMacenski in https://github.com/ros-navigation/navigation2/pull/4298 you introduced some workarounds to account for issues in BT.CPP. This ticket is a reminder to address them once the fixes are done on BT.CPP's side

SteveMacenski commented 4 months ago

Are you referring to 

add_compile_options(-Wno-shadow) # Delete after https://github.com/BehaviorTree/BehaviorTree.CPP/issues/811 is released

Or anything else?

tonynajjar commented 4 months ago

You added some more things in nav2_behavior_tree, not sure if these are workarounds or here to stay. From my stuff yes just this

SteveMacenski commented 4 months ago

Those are to stay, that's a feature of the new BT.CPP versions. Possibly a regression, but also doesn't really matter since its something that only comes up in the isolated testing environment. I could type it all out, but suffice it to say its not worth concern.

SteveMacenski commented 3 months ago

https://github.com/ros-navigation/navigation2/pull/4500 Addresses