ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.51k stars 1.27k forks source link

Nav2 Docking: Optional Collision Checking on undocking / docking #4404

Open SteveMacenski opened 3 months ago

SteveMacenski commented 3 months ago

Should be straight forward: check the future trajectory from the graceful controller for collisions, ignoring within some tolerance of the dock itself (since we're making or in contact there). We can use the costmap collision topic object from the costmap package analog to the Behavior Server's use.

ajtudela commented 3 months ago

Assign me this as it is the same behavior mentioned here: https://github.com/open-navigation/opennav_docking/pull/43. I can do both at the same time.

SteveMacenski commented 3 months ago

Lets add this in a separate PR containing just this work though, don't want to have franken-PRs that are too large to review / merge. Smaller bite sized pieces are always better. Then that can be used in your work. Might make sense for this to be an independent module used by the controller or something so that it can be unit-tested and deployed elsewhere as needed easily