ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.3k stars 1.2k forks source link

Fix unexpected behavior of docking when already in charger #4448

Closed ajtudela closed 2 weeks ago

ajtudela commented 2 weeks ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4447
Primary OS tested on (Ubuntu 22.04)
Robotic platform tested on Morphia robot
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

The fix just return, aborting the handle. It can be improve addind result / error code if necessary.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

SteveMacenski commented 2 weeks ago

@ajtudela you need to fix the unit tests

ajtudela commented 2 weeks ago

For some reason, some tests in opennav_docking were not passing, so I forgot to check the tests in this repo. It should pass them now.

SteveMacenski commented 2 weeks ago

Great, thanks!