issues
search
ros-navigation
/
navigation2
ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.3k
stars
1.2k
forks
source link
Call `gz sim` directly without `shell=True` for a clean exit
#4456
Open
azeey
opened
1 week ago
azeey
commented
1 week ago
Basic Info
Info
Please fill out this column
Ticket(s) this addresses
Primary OS tested on
Ubuntu
Robotic platform tested on
System tests on Gazebo simulation
Does this PR contain AI generated software?
No
Description of contribution in a few bullet points
https://github.com/ros-navigation/navigation2/pull/4440#issuecomment-2178985584
mentions that Gazebo needs to be SIGKILL'd. This is due to
https://github.com/ros2/launch/issues/757
where the SIGINT signal doesn't propagate to Gazebo when
shell=True
. A simple fix is to execute gz-sim directly instead of using the launch files from ros_gz.
TODO:
~If we're okay with this chance, I can update the rest of the launch files.~
For Maintainers:
[ ] Check that any new parameters added are updated in docs.nav2.org
[ ] Check that any significant change is added to the migration guide
[ ] Check that any new features
OR
changes to existing behaviors are reflected in the tuning guide
[ ] Check that any new functions have Doxygen added
[ ] Check that any new features have test coverage
[ ] Check that any new plugins is added to the plugins page
[ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
Basic Info
Description of contribution in a few bullet points
shell=True
. A simple fix is to execute gz-sim directly instead of using the launch files from ros_gz.TODO:
For Maintainers: