ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.3k stars 1.2k forks source link

Populate error_msg for all action result messages (#4341) #4460

Open aosmw opened 1 week ago

aosmw commented 1 week ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses (#4341)
Primary OS tested on Ubuntu
Robotic platform tested on none
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

First pass at populating error_msg for all action result messages.

Description of documentation updates required from your changes

Adds some new error codes to FollowWaypoints + FollowGPSWaypoints


Future work that may be required in bullet points

For Maintainers:

SteveMacenski commented 1 week ago

Let me know if you have any questions - but seems like we're covering that in the issue thread instead

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 66.50246% with 68 lines in your changes missing coverage. Please review.

Files Coverage Δ
...ior_tree/plugins/action/assisted_teleop_action.hpp 100.00% <100.00%> (ø)
...v2_behavior_tree/plugins/action/back_up_action.hpp 100.00% <100.00%> (ø)
...ugins/action/compute_path_through_poses_action.hpp 100.00% <100.00%> (ø)
...ree/plugins/action/compute_path_to_pose_action.hpp 100.00% <100.00%> (ø)
...or_tree/plugins/action/drive_on_heading_action.hpp 100.00% <100.00%> (ø)
...ehavior_tree/plugins/action/follow_path_action.hpp 100.00% <100.00%> (ø)
...e/plugins/action/navigate_through_poses_action.hpp 100.00% <100.00%> (ø)
...or_tree/plugins/action/navigate_to_pose_action.hpp 100.00% <100.00%> (ø)
...ehavior_tree/plugins/action/smooth_path_action.hpp 100.00% <100.00%> (ø)
.../nav2_behavior_tree/plugins/action/spin_action.hpp 100.00% <100.00%> (ø)
... and 23 more

... and 16 files with indirect coverage changes