ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.3k stars 1.2k forks source link

port drive on heading behavior to new gazebo #4473

Open stevedanomodolor opened 1 week ago

stevedanomodolor commented 1 week ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

mergify[bot] commented 1 week ago

This pull request is in conflict. Could you fix it @stevedanomodolor?

SteveMacenski commented 1 week ago

Addressed the merge conflict. I'm seeing this fail 2x in a row, I'm rerunning against from start to check, but there may be something up with this one.

stevedanomodolor commented 1 week ago

Yeah, this behavior seems to happen with behavior tests. I am not sure either that. I will put it on draft untill i figure out why

SteveMacenski commented 1 week ago

Yeah, these aren't flaky, they're just failing most of the time :/ I suppose we could bin these under #4349 as 'fix and rewrite'? I think they all fail from the same kinds of issues of trying to do some really strange faking out of the behaviors. Similar to migrating to GZ, I think this is similarly a "figure it out once: copy paste for the rest"

Please do put in draft