search

ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.3k stars 1.2k forks source link

bt_service_node and bt_action_node: Don't block BT loop (backport #4214 + #4234) #4475

Closed christophfroehlich closed 1 week ago

christophfroehlich commented 1 week ago

See https://github.com/ros-navigation/navigation2/pull/4408

Test results are the same for humble:

$ colcon test-result
build/nav2_behavior_tree/Testing/20240624-1845/Test.xml: 57 tests, 0 errors, 4 failures, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/cpplint.xunit.xml: 165 tests, 0 errors, 4 failures, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/test_action_navigate_through_poses_action.gtest.xml: 1 test, 0 errors, 1 failure, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/test_single_trigger_node.gtest.xml: 1 test, 0 errors, 1 failure, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/uncrustify.xunit.xml: 163 tests, 0 errors, 2 failures, 0 skipped

Summary: 811 tests, 0 errors, 12 failures, 163 skipped

and this PR

$ colcon test-result
build/nav2_behavior_tree/Testing/20240624-1907/Test.xml: 57 tests, 0 errors, 4 failures, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/cpplint.xunit.xml: 165 tests, 0 errors, 4 failures, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/test_action_navigate_through_poses_action.gtest.xml: 1 test, 0 errors, 1 failure, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/test_single_trigger_node.gtest.xml: 1 test, 0 errors, 1 failure, 0 skipped
build/nav2_behavior_tree/test_results/nav2_behavior_tree/uncrustify.xunit.xml: 163 tests, 0 errors, 2 failures, 0 skipped

Summary: 811 tests, 0 errors, 12 failures, 163 skipped
mergify[bot] commented 1 week ago

@christophfroehlich, all pull requests must be targeted towards the main development branch. Once merged into main, it is possible to backport to @humble, but it must be in main to have these changes reflected into new distributions.