ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.3k stars 1.2k forks source link

shutdown services in destructor of `ClearCostmapService` #4495

Closed GoesM closed 6 days ago

GoesM commented 6 days ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4489
Primary OS tested on Ubuntu
Robotic platform tested on gazebo simulation
Does this PR contain AI generated software? (No)

Description of contribution in a few bullet points

To avoid UAF bug mentioned in #4489

Description of documentation updates required from your changes

shutdown services in destructor of ClearCostmapService


Future work that may be required in bullet points

For Maintainers:

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files Coverage Δ
nav2_costmap_2d/src/clear_costmap_service.cpp 28.00% <100.00%> (+1.46%) :arrow_up: