fix(nav2_costmap_2d): make obstacle layer not current on enabled toggle - Githubissues

ros-navigation / navigation2

ROS 2 Navigation Framework and System

https://nav2.org/

Other

2.31k stars 1.2k forks source link

fix(nav2_costmap_2d): make obstacle layer not current on enabled toggle #4507

Closed bektaskemal closed 4 days ago

bektaskemal commented 6 days ago

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	https://github.com/ros-navigation/navigation2/issues/4465
Primary OS tested on	Ubuntu
Robotic platform tested on	Turtlebot Sim
Does this PR contain AI generated software?	No

Description of contribution in a few bullet points

Made obstacle layer consistent with other layers and make current false after enabled is toggled. So isCurrent function of costmap will return false and require update.

Future work that may be required in bullet points

For Maintainers:
- [ ] Check that any new parameters added are updated in docs.nav2.org
- [ ] Check that any significant change is added to the migration guide
- [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
- [ ] Check that any new functions have Doxygen added
- [ ] Check that any new features have test coverage
- [ ] Check that any new plugins is added to the plugins page
- [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files	Coverage Δ
nav2_costmap_2d/plugins/obstacle_layer.cpp	`76.82% <66.66%> (-0.18%)`	:arrow_down:

... and 1 file with indirect coverage changes

bektaskemal commented 5 days ago

Did you test this to get the behavior we discussed?

Yes, it works as we discussed.

SteveMacenski commented 4 days ago

Thanks for the discussion / contribution!