ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.31k stars 1.2k forks source link

Return out of map update if frames mismatch in Static Layer #4517

Closed joeyjyyang closed 3 days ago

joeyjyyang commented 4 days ago

While implementing a costmap plugin for work that behaves similar to the StaticLayer, I noticed a (possibly) missing return; in StaticLayer::incomingUpdate() for when the current frame and the incoming update's frame do not match. I say possibly because the logging seems to indicate that this is necessary, but this omission could also be intentional.


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers: