ros-navigation / navigation2

ROS 2 Navigation Framework and System
https://nav2.org/
Other
2.62k stars 1.31k forks source link

Remove nav2_loopback_sim dependency on transforms3d. (backport #4738) #4740

Closed mergify[bot] closed 3 weeks ago

mergify[bot] commented 3 weeks ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

The package never uses it, so don't declare it.

I noticed this because I noticed that recent builds of Navigation2 on Jazzy don't work on RHEL anymore, i.e. https://build.ros2.org/job/Jsrc_el9__navigation2__rhel_9__source/ is disabled. The reason for that is that python3-transforms3d is not packaged on RHEL-9. However, it turns out that this package doesn't actually use transforms3d, so the easiest thing to do here is to remove the dependency.

Note that if accepted, this should also be backported to the jazzy branch, and a new bloom-release should be done on the buildfarm for Jazzy.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

Backport to the jazzy branch.

For Maintainers:

mergify[bot] commented 3 weeks ago

@mergify[bot], all pull requests must be targeted towards the main development branch. Once merged into main, it is possible to backport to @jazzy, but it must be in main to have these changes reflected into new distributions.