ros-navigation / navigation2_tutorials

Tutorial code referenced in https://docs.nav2.org/
207 stars 136 forks source link

Add option to launch the costmap_filters as a component #67

Closed FiIipe closed 1 year ago

FiIipe commented 1 year ago

Add option to launch the costmap_filters as a component.

SteveMacenski commented 1 year ago

@AlexeyMerzlyakov please review / merge once your happy and is consistent with the website documentation

FiIipe commented 1 year ago

@AlexeyMerzlyakov thank you for reviewing my PR. I made the corrections that you requested. Thanks

FiIipe commented 1 year ago

I updated the PR, please review. I tested with namespaces, without namespaces, with composition and without composition. Seems to be working fine :)

SteveMacenski commented 1 year ago

@AlexeyMerzlyakov once you're happy, feel free to merge at your leisure - no need to wait on me.

SteveMacenski commented 1 year ago

@FiIipe @AlexeyMerzlyakov any update here?

AlexeyMerzlyakov commented 1 year ago

@FiIipe, this is kind ping for this activity. Is there any update on it? The main fix was applied to Nav2, so the tutorial update - is an important step towards a complete solution of the issue.