search

ros-noetic-arch / ros-noetic-gazebo-ros-control

ros-noetic-gazebo-ros-control AUR package
0 stars 1 forks source link

Build package with C++17 #2

Closed alexdewar closed 3 years ago

alexdewar commented 3 years ago

Fixes #1.

There seem to be two issues here:

  1. The GAZEBO_CXX_FLAGS CMake variable is added to CXXFLAGS, which adds -std=c++11
  2. The default C++ standard is < C++17

This PR fixes these issues and now the package happily builds again.

alexdewar commented 3 years ago

I've just noticed that this git tree appears to be at least one commit behind the AUR one. Let me know if you'd like me to rebase my commit.

acxz commented 3 years ago

Thanks for this @alexdewar !

acxz commented 3 years ago

@AchmadFathoni can you update the AUR package with this?

AchmadFathoni commented 3 years ago

@acxz I've added you as co-maintainer. You should be able to update it yourself.

acxz commented 3 years ago

Sweet, just updated it!

AchmadFathoni commented 3 years ago

Wait, actually the AUR already has the patch. https://github.com/AchmadFathoni/ros-noetic-gazebo-ros-control/commit/1b1ae38813bff915cd21b30a11a435826ede1426

AchmadFathoni commented 3 years ago

Now there are two -DCMAKE_CXX_STANDARD=17.

AchmadFathoni commented 3 years ago

Without this PR, the previous AUR can be build successfully already. Also no_GAZEBO_CXX_FLAGS.patch remove all GAZEBO_CXX_FLAGS. @alexdewar are you sure there is no important flag in GAZEBO_CXX_FLAGS?

AchmadFathoni commented 3 years ago

@alexdewar can you build https://aur.archlinux.org/cgit/aur.git/commit/?h=ros-noetic-gazebo-ros-control&id=1b1ae38813bff915cd21b30a11a435826ede1426 without error?

alexdewar commented 3 years ago

Yeah, it builds for me. And yes there are no other flags besides the one to set the C++ standard in GAZEBO_CXX_FLAGS.