marker creators utility

ros-perception / ar_track_alvar

AR tag tracking library for ROS

www.ros.org/wiki/ar_track_alvar

141 stars 129 forks source link

marker creators utility #45

Closed sarthou closed 6 years ago

sarthou commented 6 years ago

This pull request does not affect the classic behavior of ar_track_alvar but adds two utilities that allow you to simply create remote markers (on XYZ) and cubes with six markers.

Based on sampleMarkerCreator, it generates the PNG and XML files with the corresponding transformations.

In addition, it allows users to create color markers for more diversity.

A readme file explaining the use of the utility is present in the folder ar_track_alvar

130s commented 6 years ago

Could you rebase to the origin, which has been slightly updated? CI failed and I see memory allocation error, which may or may not be already addressed by the latest change.

sarthou commented 6 years ago

It sounds better but I do not understand why some CI have failed

sarthou commented 6 years ago

Normally, I just added some small correction and I removed a lot of warning in the ABI so these changes are interesting in my opinion, so I think it would be better to re-target this PR on the branch Melodic
No problem for the README file, I'll do it
Really sorry for spaces, my text editor does it automatically ... I'll be more careful next time

130s commented 6 years ago

Okay, then I just created melodic-devel branch and made it a default for this repo. I have to ask you to re-open a PR targeting there, as I don't think there's a feature to change the target branch on this PR. Thanks @sarthou!

130s commented 6 years ago

Note melodic-devel is based off from kinetic-devel, so you should be able to use the same branch of yours and just change the target branch when you open a new PR.