search

ros-perception / ar_track_alvar

AR tag tracking library for ROS
www.ros.org/wiki/ar_track_alvar
141 stars 129 forks source link

[CLOSED] Implement dynamic reconfigure (just for individual markers) #6

Closed 130s closed 7 years ago

130s commented 7 years ago

Issue by corot Saturday Apr 20, 2013 at 03:04 GMT _Originally opened as https://github.com/sniekum/ar_track_alvar/pull/6_

The enable/disable switch subscribes/unsubscribes to pointcloud topic, what at the same time stops the (also very CPU-hungry) depth image to pointcloud nodelet. When not subscribed, the lazy publishing of the pointcloud makes a huge saving on CPU.

_corot included the following code: https://github.com/sniekum/ar_track_alvar/pull/6/commits_

130s commented 7 years ago

Comment by corot Saturday Apr 20, 2013 at 03:19 GMT

Sorry for the junk commits; I tried to rebase but I'm terrible at git. You should take a loot at the min/max values I choose for parameters... not sure whether they make sense

130s commented 7 years ago

Comment by sniekum Saturday Apr 20, 2013 at 16:57 GMT

Can you reduce the changes in this pull request to the minimal amount of things that directly implement the dynamic reconfigure stuff? There are extraneous commits (the 6 marker things and the revert) and there are also extra changes I don't want like spacing changes in the code and commenting out of status print statements. Please clean this up and resubmit the request if you can.

130s commented 7 years ago

Comment by corot Tuesday Apr 23, 2013 at 04:07 GMT

Yes, sorry; as I told you, I tried to clean my fork but I failed. I'll re-fork and add the changes.