search

ros-perception / depthimage_to_laserscan

Converts a depth image to a laser scan for use with navigation and localization.
243 stars 163 forks source link

Build failing on melodic #31

Closed mkhansenbot closed 5 years ago

mkhansenbot commented 5 years ago

Is this package supported on melodic? I'm trying to build and getting this error.

/home/mkhansen/ros_ws/src/depthimage_to_laserscan/src/DepthImageToLaserScanNodelet.cpp:60:24: error: expected constructor, destructor, or type conversion before ‘(’ token PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet); ^ Has anyone built it for melodic?

mikaelarguedas commented 5 years ago

I think you need to use https://github.com/ros-perception/depthimage_to_laserscan/pull/27 for it to work on melodic and it hasn't been merged or released yet.

mkhansenbot commented 5 years ago

@mikaelarguedas - thanks for the pointer. I pulled your patch and it built for me. Can we get that merged?

mikaelarguedas commented 5 years ago

Can we get that merged?

@chadrockey very gentle :bellhop_bell:

mkhansenbot commented 5 years ago

@dirk-thomas - can we get #27 merged so this can build on Melodic?

chadrockey commented 5 years ago

Sorry all, I uncovered this and took care of it. https://github.com/ros/rosdistro/pull/20212

If anyone wants to provide more love to this package let me know and I'll promote you. Send me an email if possible, I've had too many Github emails over the years and can't keep track of things. Some might sitll be bouncing @willowgarage.com to this day... :\

sidshete commented 2 years ago

Replace

PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

with

PLUGINLIB_EXPORT_CLASS(depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

this should work!!

sidshete commented 2 years ago

Is this package supported on melodic? I'm trying to build and getting this error.

/home/mkhansen/ros_ws/src/depthimage_to_laserscan/src/DepthImageToLaserScanNodelet.cpp:60:24: error: expected constructor, destructor, or type conversion before ‘(’ token PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet); ^ Has anyone built it for melodic?

Replace

PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

with

PLUGINLIB_EXPORT_CLASS(depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

this should work!!