search

ros-perception / depthimage_to_laserscan

Converts a depth image to a laser scan for use with navigation and localization.
243 stars 163 forks source link

Dashing: Make depthimage_to_laserscan composable #43

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

This PR does the work to make depthimage_to_laserscan a composable node. It's a little larger than that in that it also:

  1. Does some style and whitespace cleanup
  2. Renames some header files to .hpp
  3. Changes the code so that it is composable
  4. Adds a launch file for composable nodes
clalancette commented 4 years ago

@ros-pull-request-builder retest this please

clalancette commented 4 years ago

@chadrockey Any thoughts on this? I don't want to merge it without at least a cursory glance from someone else. Thanks!

clalancette commented 4 years ago

I'm going to go ahead and merge this so I can move forward. I'm happy to take any comments after the fact and improve the code; just let me know.