ros-perception / depthimage_to_laserscan

Converts a depth image to a laser scan for use with navigation and localization.
257 stars 172 forks source link

Fix the style throughout the codebase to conform to ROS 2 style. #63

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

There are no functional changes in here, only changes to the style.

Also enable the linters so further contributions will have to conform.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 2 years ago

Same concern as ros/kdl_parser#66 (comment), but looks good otherwise. Hiding whitespace changes made this review a lot more manageable.

Using the same logic as in https://github.com/ros/kdl_parser/pull/66#issuecomment-1169958145 , I'm going to add the header and copyright holders to the LICENSE file.

clalancette commented 2 years ago

Rpr job is happy, and this is approved so going ahead and merging. Thanks for the review!