search

ros-perception / depthimage_to_laserscan

Converts a depth image to a laser scan for use with navigation and localization.
257 stars 172 forks source link

scan_offset parameter for Ros2 #80

Open YBachmann opened 4 months ago

YBachmann commented 4 months ago

Similar to this PR: https://github.com/ros-perception/depthimage_to_laserscan/pull/28 I added a scan_offset parameter for the ROS2 version.

YBachmann commented 4 months ago

@chadrockey I just wanted to aks if you could make a statement on roughly when someone could look at this PR?

clalancette commented 4 months ago

@YBachmann This is failing all of the tests because it doesn't conform to our style. Please fix the tests to pass, then we can take a look at reviewing it.

YBachmann commented 4 months ago

@YBachmann This is failing all of the tests because it doesn't conform to our style. Please fix the tests to pass, then we can take a look at reviewing it.

@clalancette The tests are now passing, sorry for not having them fixed earlier.

YBachmann commented 3 months ago

@clalancette do you have any open points you want to discuss or have changed?

PS: I also opened another PR https://github.com/ros-perception/depthimage_to_laserscan/pull/82 , I would really appreciate if you could take a look at it as well :)

YBachmann commented 3 months ago

Hello @clalancette , as some time went by, I just wanted to ping this to check if you want me to make some more changes or if this could be merged soon.