ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
129 stars 223 forks source link

[ROS2] Fix driver node status check before saving calibration data #132

Closed schornakj closed 5 years ago

schornakj commented 5 years ago

Fixes #131 , allowing the calibration .yaml file to be saved.

Currently the service fails when rclcpp::ok() returns True, which isn't the right behavior. Since this callback previously used !nh_.ok() to check the status of the camera driver, I think the ROS2 version should be using !rclcpp::ok() here instead.