search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
125 stars 220 forks source link

[ros2] Largely fixing uncrustify issues #160

Closed SteveMacenski closed 2 years ago

SteveMacenski commented 4 years ago

Hi,

We're running a coarse CI right now for ROS2 in image pipeline-land and we cloned in your master branches and we see a bunch of linting errors. I'm working to disable them from our tests, but still would be nice to just fix them outright.

This PR fixes uncrustify circa Eloquent binaries. When Foxy comes out, might have slightly different rules to take another swing at it, but this should be a much better starting point.

This was autogenerated so I don't think too much effort needs to be lent to reviewing.

mjcarroll commented 4 years ago

So looking quickly, I believe that most of this was addressed by https://github.com/ros-perception/image_common/pull/157. @SteveMacenski can you confirm?

SteveMacenski commented 4 years ago

@mjcarroll there are still 32 files with uncrustify issues. You may want to turn on the linters in CI to show these.

Martin-Idel commented 4 years ago

Yes, I believe the image_transport package should have uncrustify errors if you run the linter there - the package hasn't activated any linters and I didn't want to make my PR larger than it already was.

That would have been a followup contribution but since you're already on it, I think we should iterate here!

clalancette commented 2 years ago

I went ahead and rebased this whole thing, fixed up the remaining issues in image_transport, and enabled the linting tests. This should now be good to go, so it just needs the Rpr job, CI, and reviews.

clalancette commented 2 years ago

CI: