Fix resolving sub-namespaces incorrectly

ros-perception / image_common

Common code for working with images in ROS

http://www.ros.org/wiki/image_common

125 stars 220 forks source link

Fix resolving sub-namespaces incorrectly #188

Open devrite opened 3 years ago

devrite commented 3 years ago

Fixes #187 using get_effective_namespace instead. The new resolve_topic_name in the node topic interface is only available in rolling as far as i can tell.

devrite commented 3 years ago

Ok, there seems to be an issue with sub node creates or the effective namespace when there is no sub-namespace. For example when I create a subnode with an empty sub-namspace as an argument. I get the same error.

devrite commented 3 years ago

The namespace error should be resolved with https://github.com/ros2/rclcpp/issues/1656. But for now I am adding a check that removes any trailing slash.