Export a modern CMake target instead of variables and install includes to include/${PROJECT_NAME}

ros-perception / image_common

Common code for working with images in ROS

http://www.ros.org/wiki/image_common

125 stars 220 forks source link

Export a modern CMake target instead of variables and install includes to include/${PROJECT_NAME} #218

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Part of ament/ament_cmake#365 Part of ament/ament_cmake#292 Part of ros2/ros2#1150

This makes camera_calibration_parsers export a modern CMake target instead of old-style variables. It also makes it install includes to include/${PROJECT_NAME} to mitigate include directory search order issues when overriding packages.

sloretz commented 2 years ago

CI (build: --packages-above-and-dependencies camera_calibration_parsers test: --packages-select camera_calibration_parsers)

Linux
Linux-aarch64
macOS
Windows

sloretz commented 2 years ago

Ahh oops! I hadn't re-run CI after making a bunch of changes. Here's a bunch of jobs - if they pass no need to revert :)

Linux
Linux-aarch64
macOS
Windows

gbiggs commented 2 years ago

Sorry about that! I tested locally and it built so I got over-enthusiastic.

gbiggs commented 2 years ago

All passing, so all good.