search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
125 stars 220 forks source link

Fix cpplint errors #221

Closed jacobperron closed 2 years ago

jacobperron commented 2 years ago

Relates to https://github.com/ament/ament_lint/pull/324

jacobperron commented 2 years ago

I realized I applied linter fixes to files in the polled_camera package, but the package has not been ported to ROS 2 yet. Since pollled_camera is currently being ignored, I could not include lint fixes for it in this PR. Thoughts?

gbiggs commented 2 years ago

I realized I applied linter fixes to files in the polled_camera package, but the package has not been ported to ROS 2 yet. Since pollled_camera is currently being ignored, I could not include lint fixes for it in this PR. Thoughts?

If it's not ported to ROS 2 and is not being built, then I think it's OK to skip the ROS 2 lint fixes.

gbiggs commented 2 years ago

CI:

jacobperron commented 2 years ago

I've dropped all changes to the polled_camera package. Now there's just one commit to review (121f6ed).