Remove YAML_CPP_DLL define

ros-perception / image_common

Common code for working with images in ROS

http://www.ros.org/wiki/image_common

125 stars 220 forks source link

Closed Ace314159 closed 2 years ago

Ace314159 commented 2 years ago

Since https://github.com/ros2/yaml_cpp_vendor/issues/10 is fixed, the explicit YAML_CPP_DLL define is no longer needed and needs to be removed to prevent the macro redefinition warnings.

This should be backported to foxy and galactic.

gbiggs commented 2 years ago

CI:

jacobperron commented 2 years ago

We should backport this to the foxy branch as well.

gbiggs commented 2 years ago

I thought I'd already done it, but it turns out that was for a different PR.